Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] Separate compile_snode_tree_types from materialize_snode_tree in LLVM backends #3267

Merged

Conversation

strongoier
Copy link
Contributor

Related issue = fixes #3265

#3207 separated compile_snode_tree_types from materialize_snode_tree in the OpenGL backend. This PR does similar things for the LLVM backend.

@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: da27eeb

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/617681f49d778100071c7b88

@strongoier
Copy link
Contributor Author

/format

@strongoier strongoier marked this pull request as ready for review October 25, 2021 10:11
Copy link
Contributor

@Leonz5288 Leonz5288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@strongoier strongoier merged commit 3a9c1f3 into taichi-dev:master Oct 26, 2021
@strongoier strongoier deleted the separate-compile-snode-types-llvm branch November 1, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASM aot fails.
3 participants