Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Correct the note about dev installation #3289

Merged
merged 2 commits into from
Oct 27, 2021
Merged

[Doc] Correct the note about dev installation #3289

merged 2 commits into from
Oct 27, 2021

Conversation

sjwsl
Copy link
Collaborator

@sjwsl sjwsl commented Oct 26, 2021

Related issue = #

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 26, 2021 •
edited
Loading

❌ Deploy Preview for jovial-fermat-aa59dc failed.

🔨 Explore the source changes: 219979b

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6178ca913fa5630007111874

k-ye
k-ye approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

strongoier
strongoier reviewed Oct 26, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC develop is the correct version - can @ailzhang help confirm?

@ailzhang
Copy link
Contributor

IIUC develop is the correct version - can @ailzhang help confirm?

Yup indeed develop is the correct version here. If you used install command then it need to be rerun everytime you update any file (cpp or python) to take effect. @sjwsl Maybe you could help adding a section about install command and their differences?
https://stackoverflow.com/questions/19048732/python-setup-py-develop-vs-install

@sjwsl
Copy link
Collaborator Author

sjwsl commented Oct 26, 2021

IIUC develop is the correct version - can @ailzhang help confirm?

Yup indeed develop is the correct version here. If you used install command then it need to be rerun everytime you update any file (cpp or python) to take effect. @sjwsl Maybe you could help adding a section about install command and their differences? https://stackoverflow.com/questions/19048732/python-setup-py-develop-vs-install

Oh I got it wrong! The official documentation is a bit confusing. Will update a more clear description later. Thanks!

@sjwsl sjwsl closed this Oct 26, 2021
@sjwsl sjwsl reopened this Oct 26, 2021
strongoier
strongoier approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

docs/lang/articles/contribution/dev_install.md Outdated Show resolved Hide resolved
@sjwsl @strongoier
Update docs/lang/articles/contribution/dev_install.md
219979b 
Co-authored-by: Yi Xu <xy_xuyi@foxmail.com>
ailzhang
ailzhang approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjwsl
Copy link
Collaborator Author

sjwsl commented Oct 27, 2021

Should I squash these two commits?

@strongoier
Copy link
Contributor

Should I squash these two commits?

No manual squashing is needed. We will click squash and merge when merging PRs.

@strongoier strongoier merged commit 3c30e58 into taichi-dev:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongoier strongoier strongoier approved these changes

@ailzhang ailzhang ailzhang approved these changes

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sjwsl @CLAassistant @ailzhang @strongoier @k-ye