[gui] GGUI Image IO (well, it's actually just O...) #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 3f81d1b 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/617e688a0a9d23000804a3a6 |
AmesingFlank
changed the title
AmesingFlank
force-pushed
the
ggui_image_io
branch
from
9db029c
to
3f81d1b
Compare
help me merge it? :D |
|
3333! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds image IO for GGUI. The implementation is somewhat based on this.
Notice that this PR alone doesn't enable headlessly running GGUI: it only allows you to dump an image file while the window is also running.
In the next PR, I'll add in headless support. And then we can start adding tests for GGUI.
Not working on MoltenVK on macOS... will try to fix.
And finally, this PR should be merged after #3330, otherwise GGUI won't work at all.