[misc] Use configured headers to track version and commit hash #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: fa9c9ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6180f8125b0e420007357020 |
sjwsl
changed the title
ailzhang
reviewed
Nov 3, 2021
| "#define TI_VERSION_PATCH \"${TI_VERSION_PATCH}\"\n" | ||
| "#define TI_CUDAVERSION \"${CUDA_VERSION}\"\n" | ||
| ) | ||
| configure_file(taichi/common/version.h.in version.h) |
There was a problem hiding this comment.
Can we somehow still keep these headers in taichi/common folder? ;)
There was a problem hiding this comment.
Sure. Which one do you think is better?
- add
.insuffix to distinguish the files before and after processing - or just process them in place
There was a problem hiding this comment.
@sjwsl let's keep the .in suffix so that we know what happened there :D Thanks a lot!
There was a problem hiding this comment.
Got it. But I accidentally deleted my local branch so can't update this PR now... Could you help merge this first and then I will give another PR for this. Thanks!
sjwsl
added a commit
to sjwsl/taichi
that referenced
this pull request
Nov 3, 2021
…i-dev#3349) * [Build] Use configured header file to track version and commit hash * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating headers manually, use a more standard way to track the version and commit hash. It is easier to maintain and understand now.
Test on my local machine by building different versions.
This is the prerequisite for #3354.