Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] [refactor] Use DeviceAllocation for Ndarray #3366

Merged
merged 11 commits into from
Nov 4, 2021

Conversation

qiao-bo
Copy link
Collaborator

@qiao-bo qiao-bo commented Nov 3, 2021

In this PR we first replace the runtime-based memory allocator with device allocation. Only the basic allocate/deallocate functionalities for now.

@qiao-bo qiao-bo requested review from ailzhang and k-ye November 3, 2021 12:40
@netlify
Copy link

netlify bot commented Nov 3, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 8cd7fe8

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/618394a13ee4f300092c16ef

@qiao-bo
Copy link
Collaborator Author

qiao-bo commented Nov 3, 2021

/format

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Let's try to dedupe the code here

taichi/llvm/llvm_program.cpp Outdated Show resolved Hide resolved
taichi/llvm/llvm_program.cpp Outdated Show resolved Hide resolved
taichi/program/ndarray.cpp Outdated Show resolved Hide resolved
@qiao-bo
Copy link
Collaborator Author

qiao-bo commented Nov 4, 2021

/format

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

taichi/llvm/llvm_program.cpp Show resolved Hide resolved
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qiao-bo qiao-bo merged commit 30195de into taichi-dev:master Nov 4, 2021
@qiao-bo qiao-bo deleted the memory branch December 10, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants