Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Decouple KernelProfilerBase::sync() from Program::synchronize() #3504

Merged
merged 7 commits into from
Nov 17, 2021

Conversation

yolo2themoon
Copy link
Collaborator

Related issue = #2922

@netlify
Copy link

netlify bot commented Nov 14, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 2c39a31

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61939815b56acb0008300f5d

@yolo2themoon yolo2themoon changed the title Decoupling KernelProfilerBase::sync() from Program::synchronize() [refactor] Decoupling KernelProfilerBase::sync() from Program::synchronize() Nov 14, 2021
@yolo2themoon yolo2themoon changed the title [refactor] Decoupling KernelProfilerBase::sync() from Program::synchronize() [refactor] Decouple KernelProfilerBase::sync() from Program::synchronize() Nov 15, 2021
Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

Copy link
Collaborator

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@ailzhang ailzhang merged commit 5f26edf into taichi-dev:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants