Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add sccache to ci building process on Linux and Mac jobs #3559

Merged
merged 87 commits into from
Dec 1, 2021

Conversation

lin-hitonami
Copy link
Contributor

Related issue = #3528

@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: e36bdfa

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61a731d5c4f97200090e7a82

@lin-hitonami lin-hitonami marked this pull request as draft November 19, 2021 08:59
@lin-hitonami
Copy link
Contributor Author

lin-hitonami commented Dec 1, 2021

There seems to be some permission problem when I use docker create -v sccache_cache:/home/dev/sccache_cache to mount the cache to the docker on the github-hosted runners

Can adding :rw to the mount solve the problem?

docker create -v sccache_cache:/home/dev/sccache_cache:rw

It doesn't work. Even if I do not add rw, I can read, write, copy and delete the files. It seems that sccache performs some operations that only the file owner can do like maybe changing the mode of the files or something.

@lin-hitonami lin-hitonami marked this pull request as ready for review December 1, 2021 06:23
@frostming
Copy link
Collaborator

There seems to be some permission problem when I use docker create -v sccache_cache:/home/dev/sccache_cache to mount the cache to the docker on the github-hosted runners

Can adding :rw to the mount solve the problem?
docker create -v sccache_cache:/home/dev/sccache_cache:rw

It doesn't work. Even if I do not add rw, I can read, write, copy and delete the files. It seems that sccache performs some operations that only the file owner can do like maybe changing the mode of the files or something.

Ok, let's use the docker cp solution

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will help a looot!
Btw I've been wondering why we have both unix_build.sh and unix_docker_build.sh and it make code a lot messier.... Gonna open an issue and see if anyone has context on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants