Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix skipping presubmit checks #3569

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Conversation

sjwsl
Copy link
Collaborator

@sjwsl sjwsl commented Nov 20, 2021

Related issue = #3568

Fix and simplify the logic for skipping CI when there are no non-doc modifications.

@netlify
Copy link

netlify bot commented Nov 20, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 432476b

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/619969b7146b870007142f5c

@sjwsl sjwsl force-pushed the ci-check-files branch 15 times, most recently from 9941316 to d541b9d Compare November 20, 2021 20:04
@sjwsl sjwsl marked this pull request as ready for review November 20, 2021 20:16
@sjwsl sjwsl force-pushed the ci-check-files branch 2 times, most recently from a4b9eea to 9e3455e Compare November 20, 2021 21:29
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Thanks!

@ailzhang ailzhang merged commit e5597fd into taichi-dev:master Nov 21, 2021
sjwsl added a commit to sjwsl/taichi that referenced this pull request Nov 21, 2021
ailzhang pushed a commit to ailzhang/taichi that referenced this pull request Nov 25, 2021
ailzhang pushed a commit to ailzhang/taichi that referenced this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants