Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] GGUI initial alpha transparency support #3592

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Nov 22, 2021

Related issue = #

Just some initial work, I think we should modify device api to have the ability to specify blending ops instead of hard code it

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Nov 22, 2021

/format

@netlify
Copy link

netlify bot commented Nov 22, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 8705860

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/619b895f7d61cc0008feb989

Copy link
Contributor

@g1n0st g1n0st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AmesingFlank
Copy link
Collaborator

Thanks!

Please also change the ti.scene(color = ) API to support rgba as well. (need to update python/ui/scene.py and taichi/python/export_ggui.cpp)

@AmesingFlank
Copy link
Collaborator

Thanks!

Please also change the ti.scene(color = ) API to support rgba as well. (need to update python/ui/scene.py and taichi/python/export_ggui.cpp)

But we can merge this one first to unblock YuChang.

@g1n0st g1n0st merged commit 6ee0a0d into taichi-dev:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants