Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix postsubmit #3661

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

lin-hitonami
Copy link
Contributor

Related issue = #

@netlify
Copy link

netlify bot commented Dec 1, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: febb840

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61a726635dc1d3000883a3df

😎 Browse the preview: https://deploy-preview-3661--jovial-fermat-aa59dc.netlify.app

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit is messed up with dev_install ;P

@lin-hitonami
Copy link
Contributor Author

Seems that misc/code_format.py auto-formatted the docs...

@ailzhang
Copy link
Contributor

ailzhang commented Dec 1, 2021

Hmmm then it might indicate that our dev_install does need a format... weird... let me try this...

@ailzhang
Copy link
Contributor

ailzhang commented Dec 1, 2021

/format

@ailzhang
Copy link
Contributor

ailzhang commented Dec 1, 2021

Alright, let's just include the format changes here. Something must be wrong with the doc-only presubmit workflow... We need to turn on format check for them

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ailzhang
Copy link
Contributor

ailzhang commented Dec 1, 2021

One CPU test passed, merging to unblock master,

@ailzhang ailzhang merged commit bd734d1 into taichi-dev:master Dec 1, 2021
@lin-hitonami lin-hitonami deleted the fix-postsubmit branch January 7, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants