[refactor] Remove unused functions in misc. #3671
Conversation
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 8e3620a 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61a85e430bf21200087a7742 |
| @@ -230,26 +197,6 @@ def get_kernel_stats(): | |||
| return _ti_core.get_kernel_stats() | |||
|
|
|||
|
|
|||
| def print_async_stats(include_kernel_profiler=False): | |||
There was a problem hiding this comment.
This function seems related to our async project. @k-ye wdyt?
There was a problem hiding this comment.
@strongoier I deleted mainly because it wasn't even in the __all__ in this file, so it's very likely that this one is not used...
There was a problem hiding this comment.
This is some random util function...
ailzhang
force-pushed
the
remove_unused_misc
branch
from
9ffe761
to
d87024b
Compare
| from colorama import Fore | ||
|
|
||
|
|
||
| def enable_excepthook(): |
There was a problem hiding this comment.
Not sure if we definitely want to remove this. If we finally decide to remove this, we can remove all _taichi_skip_traceback in the codebase and all docs or configs related to this feature (https://github.com/taichi-dev/taichi/search?q=excepthook).
As we have @lin-hitonami 's new error report mechanism now, do we still want to keep the hacky pretty printing of the traceback stack? @k-ye
There was a problem hiding this comment.
I'm fully down to remove _taichi_skip_traceback :D
|
@strongoier Yea that one should be separate PR for sure, I'll open an issue first to see if anyone is interested ;) |
Related issue = #