[refactor] Let build_xxx in ASTTransformer return node.ptr instead of node #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 0098bf4 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61af133deabf9e00072f4c69 |
strongoier
suggested changes
Dec 7, 2021
There was a problem hiding this comment.
Would you merge with master branch? I think there must be something to resolve as #3709 is in now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3694
This is a necessary refactoring to resolve #3694.
Since we do not modify the AST anymore after the refactoring, we do not need to assign the new node back to the old node in the AST. So, we can simplify the programming by returning node.ptr in build_xxx of expression nodes and None for build_xxx of statement nodes. In this way, many codes like
a = build_stmt(ctx, b).ptrcan be simplified toa = build_stmt(ctx, b).ASTTransformerCheck will be removed in the near future, the modification to it is just a workaround to pass the tests of real functions with multiple returns.