Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Auto generate manylinux dockerfile #3699

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Conversation

qiao-bo
Copy link
Collaborator

@qiao-bo qiao-bo commented Dec 3, 2021

Add an option in the script to generate our CentOS based dockerfile: python Dockerfile_generator.py -o manylinux2014 -t cpu. Locally tested.

@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: d2519ed

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61af149509cacc0008f07ad0

@qiao-bo
Copy link
Collaborator Author

qiao-bo commented Dec 3, 2021

/format

Copy link
Collaborator

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Btw, the generated Dockerfile using the cli is slightly different from the existing manylinux one, shall we overwrite the existing one?

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add "#generated by python bla.. config" on top of the generated Dockerfile? ;)

@qiao-bo
Copy link
Collaborator Author

qiao-bo commented Dec 7, 2021

/format

@qiao-bo qiao-bo merged commit 4fb0ce6 into taichi-dev:master Dec 7, 2021
@qiao-bo qiao-bo deleted the generator branch December 7, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants