Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vulkan] Add support of loading AOT modules and fields #3703

Merged
merged 1 commit into from
Dec 8, 2021
Merged

[Vulkan] Add support of loading AOT modules and fields #3703

merged 1 commit into from
Dec 8, 2021

Conversation

ghuau-innopeak
Copy link
Collaborator

Related issue = #3679

@netlify
Copy link

netlify bot commented Dec 3, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 3aa620f

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61ae3ddc3c59020008f1f85a

@ghuau-innopeak
Copy link
Collaborator Author

For to_vk_dtype_enum, right now, I'm using constant values with a static function, but I'm wondering if we even need to serialize dtype as we already serialize the name?

@ghuau-innopeak ghuau-innopeak changed the title [Vulkan] add support of loading AOT modules and fields [Vulkan] Add support of loading AOT modules and fields Dec 4, 2021
ailzhang
ailzhang approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!
Shall we add a C++ test saving & loading as followup? ;)

taichi/backends/vulkan/aot_module_builder_impl.cpp Outdated
void AotModuleBuilderImpl::load(const std::string &output_dir,
const std::string &filename) {
const std::string bin_path =
fmt::format("{}/{}_metadata.tcb", output_dir, filename);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: filename is no longer used? ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad! should be fixed :)

@ghuau-innopeak
Copy link
Collaborator Author

Looks great! Thanks! Shall we add a C++ test saving & loading as followup? ;)

@ailzhang Indeed, and some example code in C++ for aot_save was merged recently that could be re-used for testing too (#3707)

@ailzhang ailzhang merged commit 1192943 into taichi-dev:master Dec 8, 2021
ailzhang added a commit that referenced this pull request Dec 8, 2021
@ailzhang
Revert "[Vulkan] Add support of loading AOT modules and fields (#3703)"
d340bdf 
This reverts commit 1192943.
@ailzhang ailzhang mentioned this pull request Dec 8, 2021
Closed
@ghuau-innopeak ghuau-innopeak deleted the ghuau/vulkan_aot_loading branch December 14, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghuau-innopeak @ailzhang