Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metal] Pass random seed to metal backend #3724

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

knight42
Copy link
Member

@knight42 knight42 commented Dec 6, 2021

Signed-off-by: knight42 anonymousknight96@gmail.com

Related issue = #2734

/cc @k-ye

I am not sure if the current implementation is desired since I don't know much about cpp 😢 , any advice is welcome!

Signed-off-by: knight42 <anonymousknight96@gmail.com>
Signed-off-by: knight42 <anonymousknight96@gmail.com>
@netlify
Copy link

netlify bot commented Dec 6, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 19c5826

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61af414a1d1d350009d9d56d

@knight42 knight42 requested a review from k-ye December 6, 2021 12:20
@knight42 knight42 changed the title [Lang][Metal] feat: pass random seed to metal backend [Lang] [Metal] Pass random seed to metal backend Dec 6, 2021
@knight42 knight42 changed the title [Lang] [Metal] Pass random seed to metal backend [Metal] Pass random seed to metal backend Dec 6, 2021
tests/python/test_random.py Outdated Show resolved Hide resolved
@knight42 knight42 requested a review from k-ye December 8, 2021 06:34
@knight42
Copy link
Member Author

knight42 commented Dec 8, 2021

@k-ye Hi! All tests passed now! Would you like to take a second look?

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@k-ye k-ye merged commit ec1a90d into taichi-dev:master Dec 8, 2021
@knight42 knight42 deleted the feat/metal-random-seed branch December 8, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants