Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Add /bigobj flag to allow Debug builds on windows #3730

Merged
merged 1 commit into from
Dec 7, 2021
Merged

[build] Add /bigobj flag to allow Debug builds on windows #3730

merged 1 commit into from
Dec 7, 2021

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Dec 7, 2021

Related issue = #

@netlify
Copy link

netlify bot commented Dec 7, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 0768d2f

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61aee3d3eabf9e00072aa3c3

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Dec 7, 2021

This flag won't make the object files themselves larger, but rather just allow more sections to be present in a file.

ailzhang
ailzhang approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobcao3 bobcao3 merged commit 93ddca4 into taichi-dev:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@frostming frostming frostming approved these changes

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobcao3 @ailzhang @frostming