Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Move ti.lib to ti._lib and move ti.core to ti._lib.core #3731

Merged
merged 35 commits into from
Dec 14, 2021
Merged

[refactor] Move ti.lib to ti._lib and move ti.core to ti._lib.core #3731

merged 35 commits into from
Dec 14, 2021

Conversation

lin-hitonami
Copy link
Contributor

Related issue = #

@netlify
Copy link

netlify bot commented Dec 7, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 049a406

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61b806a3e714b70008100f1f

@lin-hitonami
Copy link
Contributor Author

/format

@lin-hitonami lin-hitonami changed the title [refactor] Move ti.core to ti.lib.core [refactor] Move ti.lib to ti._lib and move ti.core to ti._lib.core Dec 8, 2021
@lin-hitonami lin-hitonami marked this pull request as draft December 8, 2021 11:54
@lin-hitonami lin-hitonami marked this pull request as ready for review December 10, 2021 10:06
@lin-hitonami
Copy link
Contributor Author

Since the vulkan support for M1 without installing molten-vk or vulkan sdk seems broken even in the master branch, I cannot test whether my change broke it or not.

strongoier
strongoier suggested changes Dec 12, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts to be handled as #3774 is in :-)

@lin-hitonami lin-hitonami requested review from strongoier and ailzhang and removed request for strongoier, ailzhang, k-ye and bobcao3 December 14, 2021 02:51
ailzhang
ailzhang approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ailzhang ailzhang merged commit 6d9c86b into taichi-dev:master Dec 14, 2021
@lin-hitonami lin-hitonami deleted the lib_core branch January 7, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@strongoier strongoier Awaiting requested review from strongoier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lin-hitonami @strongoier @ailzhang