Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Unnecessary assignment as it is redefined #3753

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

tszdanger
Copy link
Contributor

Related issue = #

Related issue = close #3752

Raise the performance by reducing the unnecessary checks in ``if`` condition.
Unnecessary assignment as it is redefined. Here res is on line 693 is not necessary.
@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 30bcca4

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61b0afaaf408720007d15ce9

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@ailzhang ailzhang merged commit 857eee8 into taichi-dev:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary assignment as it is redefined
2 participants