Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [cuda] Fix memset before reusing cuda cached memory #3841

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

qiao-bo
Copy link
Collaborator

@qiao-bo qiao-bo commented Dec 20, 2021

This prevents any side effect when read/write to the cached memory returned by ndarray memory allocator.

@netlify
Copy link

netlify bot commented Dec 20, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: cd4a89b

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61c04850e2a57b0008813fbf

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@qiao-bo qiao-bo merged commit d3b37d1 into taichi-dev:master Dec 20, 2021
@qiao-bo qiao-bo deleted the memory branch December 20, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants