Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ir] [refactor] Split stmt typechecking to the frontend #3875

Merged
merged 1 commit into from
Jan 15, 2022
Merged

[ir] [refactor] Split stmt typechecking to the frontend #3875

merged 1 commit into from
Jan 15, 2022

Conversation

re-xyr
Copy link
Contributor

@re-xyr re-xyr commented Dec 25, 2021

Related issue = close #3633

Remaining issues:

  • TypeErrors thrown by frontend stmt typechecker are not catched and wrapped into TaichiCompilationError for now

@netlify
Copy link

netlify bot commented Dec 25, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: b70dd71

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61da89add8f74200081b4a5d

😎 Browse the preview: https://deploy-preview-3875--jovial-fermat-aa59dc.netlify.app

@re-xyr re-xyr force-pushed the frontend_type_check branch 2 times, most recently from b38d135 to fa0eb36 Compare December 25, 2021 05:08
strongoier
strongoier approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taichi/transforms/frontend_type_check.cpp Outdated Show resolved Hide resolved
taichi/transforms/frontend_type_check.cpp Outdated Show resolved Hide resolved
@strongoier strongoier changed the title [lang] Split stmt typechecking to the frontend (#3633) [Lang] Split stmt typechecking to the frontend Dec 29, 2021
@re-xyr re-xyr force-pushed the frontend_type_check branch 2 times, most recently from 1607618 to b70dd71 Compare January 9, 2022 07:07
strongoier
strongoier suggested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Keep consistent usage of curly braces when there is only one statement inside a block.
  2. We can further make report_condition_type_error into check_condition_type with if included.

taichi/transforms/frontend_type_check.cpp Outdated Show resolved Hide resolved
taichi/transforms/frontend_type_check.cpp Outdated Show resolved Hide resolved
taichi/transforms/frontend_type_check.cpp Outdated Show resolved Hide resolved
taichi/transforms/frontend_type_check.cpp Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jan 15, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/HBZbcwMZXKFc2x2B4XqeSP8QrG7E
✅ Preview: Canceled

[Deployment for d693ad5 canceled]

@netlify
Copy link

netlify bot commented Jan 15, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: d693ad5

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61e2420e40ba5d0007bcb772

😎 Browse the preview: https://deploy-preview-3875--docsite-preview.netlify.app

@strongoier strongoier changed the title [Lang] Split stmt typechecking to the frontend [ir] [refactor] Split stmt typechecking to the frontend Jan 15, 2022
strongoier
strongoier approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 3234192 into taichi-dev:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye left review comments

@strongoier strongoier strongoier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support frontend type check for If/While statements
3 participants
@re-xyr @strongoier @k-ye