Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autodiff] Restrict Independent Block scope for cases with atomic operations on global variables #3897

Merged
merged 22 commits into from
Jan 14, 2022
Merged

[autodiff] Restrict Independent Block scope for cases with atomic operations on global variables #3897

merged 22 commits into from
Jan 14, 2022

Conversation

erizmr
Copy link
Contributor

@erizmr erizmr commented Dec 28, 2021 •
edited
Loading

Related issue = #3912

@netlify
Copy link

netlify bot commented Dec 28, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 83044d6

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61dfdf61dd9779000742086b

😎 Browse the preview: https://deploy-preview-3897--jovial-fermat-aa59dc.netlify.app

@erizmr erizmr mentioned this pull request Dec 30, 2021
Closed
@erizmr erizmr changed the title [autodiff] Detect and raise error info for autodiff kernel simplicity rule [autodiff] Restrict Independent Block scope for cases with atomic operations on global variables Jan 12, 2022
@erizmr erizmr changed the title [autodiff] Restrict Independent Block scope for cases with atomic operations on global variables [autodiff] Restrict Independent Block scope for cases with atomic operations on global variables Jan 12, 2022
@erizmr erizmr requested a review from ailzhang January 13, 2022 02:16
ailzhang
ailzhang reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

taichi/transforms/auto_diff.cpp Outdated Show resolved Hide resolved
taichi/transforms/auto_diff.cpp Outdated Show resolved Hide resolved
taichi/transforms/auto_diff.cpp Outdated Show resolved Hide resolved
tests/python/test_ad_for.py Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jan 14, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/8xj6nSEvGUDPSJZAYHJ4DMtPCYGF
✅ Preview: Canceled

[Deployment for 3412bbd canceled]

@netlify
Copy link

netlify bot commented Jan 14, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 3412bbd

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61e10a21bf5c7600079a5186

😎 Browse the preview: https://deploy-preview-3897--docsite-preview.netlify.app

@erizmr erizmr requested a review from ailzhang January 14, 2022 02:58
ailzhang
ailzhang approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@ailzhang ailzhang merged commit fa5a266 into taichi-dev:master Jan 14, 2022
@erizmr erizmr deleted the autodiff-fix2 branch January 16, 2022 15:02
@erizmr erizmr mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erizmr @ailzhang @taichi-gardener