Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Update camera.py #3898

Merged
merged 1 commit into from
Dec 30, 2021
Merged

[gui] Update camera.py #3898

merged 1 commit into from
Dec 30, 2021

Conversation

95833
Copy link
Contributor

@95833 95833 commented Dec 28, 2021

wrong method name

@CLAassistant
Copy link

CLAassistant commented Dec 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Dec 28, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: c04047b

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61cb3f3b41cdc10007ce2dbc

AmesingFlank
AmesingFlank approved these changes Dec 29, 2021
View reviewed changes
Copy link
Collaborator

@AmesingFlank AmesingFlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. thanks!

@bobcao3 bobcao3 changed the title Update camera.py [gui] Update camera.py Dec 30, 2021
@bobcao3
Copy link
Collaborator

bobcao3 commented Dec 30, 2021

@stamnug Just need to sign the CLA, thanks for your contribution!

ailzhang
ailzhang approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ailzhang ailzhang merged commit 0abce04 into taichi-dev:master Dec 30, 2021
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request Jan 5, 2022
@95833 @quadpixels
[gui] Update camera.py (taichi-dev#3898)
e4f216b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@AmesingFlank AmesingFlank AmesingFlank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@95833 @CLAassistant @bobcao3 @ailzhang @AmesingFlank