[opengl] Cache loaded arr elements. #3901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: implementation is a bit hacky, for testing only... Noticed that we're reloading the same elements in ndarrays again and again in the opengl generated code. This doesn't affect JIT perf on NV GPUs but I'm suspicious that it's one source of bottleneck on snapdragon android. Unlike read-only shape information saved in args buffer, cached ndarray elements should be invalidated once it's overwritten. [ghstack-poisoned]
This was referenced Dec 29, 2021
ailzhang
pushed a commit
that referenced
this pull request
Dec 29, 2021
WIP: implementation is a bit hacky, for testing only... Noticed that we're reloading the same elements in ndarrays again and again in the opengl generated code. This doesn't affect JIT perf on NV GPUs but I'm suspicious that it's one source of bottleneck on snapdragon android. Unlike read-only shape information saved in args buffer, cached ndarray elements should be invalidated once it's overwritten. ghstack-source-id: b0421029dce09397b8b0f2a71b77221f43705d3d Pull Request resolved: #3901
WIP: implementation is a bit hacky, for testing only... Noticed that we're reloading the same elements in ndarrays again and again in the opengl generated code. This doesn't affect JIT perf on NV GPUs but I'm suspicious that it's one source of bottleneck on snapdragon android. Unlike read-only shape information saved in args buffer, cached ndarray elements should be invalidated once it's overwritten. [ghstack-poisoned]
ailzhang
pushed a commit
that referenced
this pull request
Dec 29, 2021
WIP: implementation is a bit hacky, for testing only... Noticed that we're reloading the same elements in ndarrays again and again in the opengl generated code. This doesn't affect JIT perf on NV GPUs but I'm suspicious that it's one source of bottleneck on snapdragon android. Unlike read-only shape information saved in args buffer, cached ndarray elements should be invalidated once it's overwritten. ghstack-source-id: b0421029dce09397b8b0f2a71b77221f43705d3d Pull Request resolved: #3901
WIP: implementation is a bit hacky, for testing only... Noticed that we're reloading the same elements in ndarrays again and again in the opengl generated code. This doesn't affect JIT perf on NV GPUs but I'm suspicious that it's one source of bottleneck on snapdragon android. Unlike read-only shape information saved in args buffer, cached ndarray elements should be invalidated once it's overwritten. [ghstack-poisoned]
ailzhang
pushed a commit
that referenced
this pull request
Dec 29, 2021
WIP: implementation is a bit hacky, for testing only... Noticed that we're reloading the same elements in ndarrays again and again in the opengl generated code. This doesn't affect JIT perf on NV GPUs but I'm suspicious that it's one source of bottleneck on snapdragon android. Unlike read-only shape information saved in args buffer, cached ndarray elements should be invalidated once it's overwritten. ghstack-source-id: 7ae7a18286a8ac6fcc8f1ed3e8f22132e1441e70 Pull Request resolved: #3901
|
superseded by #3992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
WIP: implementation is a bit hacky, for testing only...
Noticed that we're reloading the same elements in ndarrays again and
again in the opengl generated code. This doesn't affect JIT perf on NV
GPUs but I'm suspicious that it's one source of bottleneck on snapdragon
android.
Unlike read-only shape information saved in args buffer, cached ndarray
elements should be invalidated once it's overwritten.