[opengl] [aot] Convert opengl aot to dump ModuleData. #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 954618f 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61dd302502cad80008b98b56 |
k-ye
reviewed
Jan 11, 2022
taichi/aot/module_data.h
Outdated
| @@ -33,11 +33,10 @@ struct CompiledFieldData { | |||
| struct CompiledOffloadedTask { | |||
| std::string type; | |||
| std::string name; | |||
| // Do we need to inline the source code? | |||
| std::string source_path; | |||
| std::string source; | |||
There was a problem hiding this comment.
Are we directly inlining the shaders now? What about SPIR-V?
There was a problem hiding this comment.
@k-ye good point! Hmmm I'll revert this back to source_path, and move writing to "spv/glsl" files to convert() instead.
ailzhang
force-pushed
the
refactor_ogl
branch
2 times, most recently
from
0f426d2
to
a2da3b1
Compare
ailzhang
force-pushed
the
refactor_ogl
branch
from
a2da3b1
to
954618f
Compare
Leonz5288
added a commit
to Leonz5288/taichi
that referenced
this pull request
Jan 26, 2022
…-dev#3991)" This reverts commit 473a91c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switch opengl backend to dump
ModuleDatainstead of its own structure.Followup: need to update the deserializer accordingly for bind_index.