[vulkan] [aot] Enable aot tests for vulkan backend. #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a typo in std::optional serialization and enabled field based aot tests for vulkan backend. Note our `arch` in `ti.aot.Module(arch)` API is ignored, this API is a bit misleading so we made it clear in tests.
|
✔️ Deploy Preview for jovial-fermat-aa59dc ready! 🔨 Explore the source changes: c958b8a 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61de3a36e3edc70008ebf5c1 😎 Browse the preview: https://deploy-preview-4000--jovial-fermat-aa59dc.netlify.app |
|
synk error is not related, merging :D |
ailzhang
pushed a commit
to ailzhang/taichi
that referenced
this pull request
Jan 13, 2022
related: taichi-dev#3334 I made a mistake in taichi-dev#4000 that vulkan aot doesn't support templated kernel yet. This PR made it an explicit error and split the tests. ghstack-source-id: 37e5c95677706c9e49336c65c7bd3004058820b1 Pull Request resolved: taichi-dev#4010
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in std::optional serialization and enabled field
based aot tests for vulkan backend.
Note our
archinti.aot.Module(arch)API is ignored, this API is a bitmisleading so we made it clear in tests.
Related issue = #