Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] GGUI imwrite BGRA to RGBA conversion #4018

Merged
merged 2 commits into from
Jan 14, 2022
Merged

[gui] GGUI imwrite BGRA to RGBA conversion #4018

merged 2 commits into from
Jan 14, 2022

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jan 13, 2022 •
edited
Loading

Fixes #4005

@netlify
Copy link

netlify bot commented Jan 13, 2022 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 83f6119

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61dfa6ec293cd80008121ed5

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Jan 13, 2022

/format

@neozhaoliang
Copy link
Contributor

neozhaoliang commented Jan 13, 2022 •
edited
Loading

@bobcao3 Do you mind add [explanatory comments / reference to this issue] in the code to help future developers ?

AmesingFlank
AmesingFlank approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@AmesingFlank AmesingFlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ailzhang ailzhang merged commit cf781d9 into taichi-dev:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmesingFlank AmesingFlank AmesingFlank approved these changes

@neozhaoliang neozhaoliang neozhaoliang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RGB channel order by ti.ui.Window.write_image() not correct
5 participants
@bobcao3 @neozhaoliang @AmesingFlank @ailzhang @taichi-gardener