Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Disable LTO for mac. #4027

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Conversation

ailzhang
Copy link
Contributor

Fixes #3939.

I have AppleClang12.0.5 and enabling lto=thin made linking
extremely slow here. Need to check if it's related to my clang version.
But let's disable it first :P.

Related issue = #

Fixes taichi-dev#3939.

I have AppleClang12.0.5 and enabling lto=thin made linking
extremely slow here. Need to check if it's related to my clang version.
But let's disable it first :P.
@vercel
Copy link

vercel bot commented Jan 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/Hs2WFLcaJ94zB4tPim6kNQGRGV8D
✅ Preview: Canceled

@netlify
Copy link

netlify bot commented Jan 14, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: d3c557c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61e109616e90ad0009599842

Copy link
Member

@turbo0628 turbo0628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It also works on my laptop with clang 11.1.0 (conda build), macOS 11.6.1.
I didn't notice performance regression. We can add this option back when we are strict on compilation speed.

@ailzhang ailzhang merged commit 0d58520 into taichi-dev:master Jan 14, 2022
@ailzhang ailzhang deleted the disable_lto_mac branch January 14, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linking got slower on my m1 mac
2 participants