Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix bug that building with TI_WITH_LLVM=OFF will fail #4043

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Jan 17, 2022

Related issue = fix #3999

Taichi isn't at a state that can be built easily without LLVM at all. Currently, the -DTI_WITH_LLVM=OFF doesn't mean that Taichi will be built without using LLVM at all. Fixing this problem completely in the future version is that we should consider, which is difficult but necessary.

@vercel
Copy link

vercel bot commented Jan 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/9yz2pTdR3k9cGjpLYhQ6XMMnVYq3
✅ Preview: Canceled

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 171fe60

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61e513390edb7600086cdd93

😎 Browse the preview: https://deploy-preview-4043--docsite-preview.netlify.app

@strongoier strongoier changed the title [bug] Fix bug that building with TI_WITH_LLVM=OFF will fail. [bug] Fix bug that building with TI_WITH_LLVM=OFF will fail Jan 17, 2022
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@strongoier strongoier merged commit 016feb3 into taichi-dev:master Jan 18, 2022
@PGZXB PGZXB deleted the dev-for-issue3999 branch January 21, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[llvm] build without llvm option fails
2 participants