Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Refactor Runtime to decouple the SNodeTree part #4380

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Feb 24, 2022

Related issue = #3642

Created a SNodeTreeManager to group SNodeTree related methods. This can make VkRuntime a bit cleaner. Hopefully VkRuntime can be directly exposed in our AOT library.

@netlify
Copy link

netlify bot commented Feb 24, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: cca5926

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62176ba8c459820008348693

@k-ye
Copy link
Member Author

k-ye commented Feb 24, 2022

/format

Copy link
Collaborator

@ghuau-innopeak ghuau-innopeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k-ye k-ye merged commit d420249 into taichi-dev:master Feb 25, 2022
@k-ye k-ye deleted the vk-snode-mgr branch February 25, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants