Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aot] [vulkan] Output shapes/dims to AOT exported module #4382

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

ghuau-innopeak
Copy link
Collaborator

Related issue = #3642

This is needed for NdArray support as well as exporting the DeviceAllocation symbol to external libraries.

@netlify
Copy link

netlify bot commented Feb 24, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: 8fd0149

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/621844ab047e3600077532c2

This is needed when loading the AOT module so the args of the kernel can
be filled properly.
@ghuau-innopeak ghuau-innopeak changed the title [aot] [vulkan] output shapes/dims to AOT exported module [aot] [vulkan] Output shapes/dims to AOT exported module Feb 24, 2022
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, o.w. LGTM!

taichi/backends/vulkan/aot_module_builder_impl.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taichi/backends/vulkan/aot_module_builder_impl.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants