[vulkan] [aot] Move add_root_buffer to public members #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 615af03 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62194c7c0071c000075c2958 |
ghuau-innopeak
force-pushed
the
ghuau/dev
branch
from
ef5d2af
to
6392c4d
Compare
ghuau-innopeak
changed the title
This is requires for AOT module when loaded to create the initial root buffer.
ghuau-innopeak
force-pushed
the
ghuau/dev
branch
from
6392c4d
to
615af03
Compare
ghuau-innopeak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is requires for AOT module when loaded to create the initial root
buffer otherwise they cannot create the buffer, only the SNodeTreeManager
class has access to it which is not used in the case of AOT.
Related issue = #3642