[metal] Support device memory allocation/deallocation #4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: ddd608b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62259c47b9466a0007b61d0f |
k-ye
changed the title
qiao-bo
reviewed
Mar 4, 2022
ailzhang
approved these changes
Mar 4, 2022
taichi/backends/metal/device.cpp
Outdated
| res.device = this; | ||
| res.alloc_id = allocations_.size(); | ||
|
|
||
| auto &ialloc = allocations_[res.alloc_id]; // "i" for internal |
There was a problem hiding this comment.
super nit: I personally prefer to explicitly spell out the type when it's short to help code readability :P But I'm definitely aware that people have different opinions. Maybe good to align on this internally in the future? ;)
There was a problem hiding this comment.
+1 on explicitly writing out the type. Maybe https://google.github.io/styleguide/cppguide.html#Type_deduction ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2736