Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error] Add error message when the number of elements in kernel arguments exceed #4444

Merged
merged 5 commits into from
Mar 8, 2022

Conversation

mzmzm
Copy link
Contributor

@mzmzm mzmzm commented Mar 4, 2022

Add error message when the number of elements in kernel arguments exceeds.

@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: d0bd5a4

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/6227055d09e12e000706096c

😎 Browse the preview: https://deploy-preview-4444--docsite-preview.netlify.app

@mzmzm mzmzm requested a review from strongoier March 4, 2022 05:47
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests :-)

python/taichi/lang/kernel_impl.py Outdated Show resolved Hide resolved
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzmzm mzmzm merged commit 159895c into taichi-dev:master Mar 8, 2022
@mzmzm mzmzm deleted the fix_error branch March 8, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants