-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mesh] Refactor MeshTaichi API #6306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 12, 2022 12:24
7dcf852
to
c0522f2
Compare
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 12, 2022 12:43
40037e0
to
8b8bdef
Compare
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 12, 2022 13:38
4de6438
to
5725e07
Compare
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 12, 2022 14:26
83e5b6c
to
0952b64
Compare
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 13, 2022 07:50
1ee946e
to
21ac9d4
Compare
BillXu2000
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 13, 2022 10:35
fb5d636
to
60105d9
Compare
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 13, 2022 11:18
03ea51b
to
59fe2d6
Compare
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 13, 2022 12:16
81bdc56
to
2680710
Compare
g1n0st
force-pushed
the
mesh-api-refactor
branch
from
October 13, 2022 12:52
9b64418
to
aea1339
Compare
for more information, see https://pre-commit.ci
This was referenced Oct 15, 2022
g1n0st
added a commit
that referenced
this pull request
Oct 19, 2022
continue from: #6306 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
jim19930609
pushed a commit
to jim19930609/taichi
that referenced
this pull request
Oct 31, 2022
continue from: taichi-dev#6306 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3608
This PR is targeting for officially releasing MeshTaichi. For simplifying the usage and deprecating out-dated design decisions, we would like to update MeshTaichi front-end APIs:
Current:
Updated:
Full updates:
get_position_as_numpy()
instead of implicit data copy