Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Get the length of dynamic SNode by x.length() #6750

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

lin-hitonami
Copy link
Contributor

Issue: #5420
Just noticed that we forgot to enable getting length of dynamic SNode by x[i].length() along with append and deactivate

Brief Summary

@lin-hitonami lin-hitonami added this to the v1.3.0 milestone Nov 28, 2022
@feisuzhu
Copy link
Contributor

/rerun

@feisuzhu feisuzhu closed this Nov 28, 2022
@feisuzhu feisuzhu reopened this Nov 28, 2022
@lin-hitonami lin-hitonami changed the title [lang] Get length of dynamic SNode by x[i].length() [lang] Get length of dynamic SNode by x.length() Nov 28, 2022
@lin-hitonami lin-hitonami changed the title [lang] Get length of dynamic SNode by x.length() [lang] Get the length of dynamic SNode by x.length() Nov 28, 2022
@lin-hitonami lin-hitonami merged commit 797feaf into taichi-dev:master Nov 28, 2022
@lin-hitonami lin-hitonami deleted the add_length branch November 28, 2022 12:06
@lin-hitonami lin-hitonami restored the add_length branch November 28, 2022 12:06
@lin-hitonami lin-hitonami deleted the add_length branch November 28, 2022 12:06
lin-hitonami added a commit to lin-hitonami/taichi that referenced this pull request Nov 29, 2022
Issue: taichi-dev#5420
Just noticed that we forgot to enable getting length of dynamic SNode by
`x[i].length()` along with `append` and `deactivate`
### Brief Summary
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#5420
Just noticed that we forgot to enable getting length of dynamic SNode by
`x[i].length()` along with `append` and `deactivate`
### Brief Summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants