Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update the documentation about Dynamic SNode #6752

Merged
merged 23 commits into from
Nov 29, 2022

Conversation

lin-hitonami
Copy link
Contributor

Issue: #5420

Brief Summary

@lin-hitonami lin-hitonami added this to the v1.3.0 milestone Nov 28, 2022
@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit c2aeccf
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6385b96b46421d000b3edb34
😎 Deploy Preview https://deploy-preview-6752--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
neozhaoliang and others added 3 commits November 29, 2022 10:46
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
@neozhaoliang neozhaoliang self-requested a review November 29, 2022 03:00
lin-hitonami and others added 4 commits November 29, 2022 11:04
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
@lin-hitonami
Copy link
Contributor Author

Applied the changes with some minor changes. Please review again.

Copy link
Contributor

@Olinaaaloompa Olinaaaloompa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one little style issue: We can spell out the numbers below 10 for consistency.

docs/lang/articles/basic/sparse.md Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
@lin-hitonami
Copy link
Contributor Author

Added the usage of append, length, and deactivate.

Copy link
Contributor

@Olinaaaloompa Olinaaaloompa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A grammar suggestion. Otherwise it is all fine :)

docs/lang/articles/basic/sparse.md Outdated Show resolved Hide resolved
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
@lin-hitonami lin-hitonami merged commit c92db2a into taichi-dev:master Nov 29, 2022
@lin-hitonami lin-hitonami deleted the dynamic_doc branch November 29, 2022 09:11
lin-hitonami added a commit to lin-hitonami/taichi that referenced this pull request Nov 29, 2022
Issue: taichi-dev#5420

### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Zhao Liang <mathzhaoliang@gmail.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#5420

### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Zhao Liang <mathzhaoliang@gmail.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants