-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update the documentation about Dynamic SNode #6752
Conversation
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
Co-authored-by: Zhao Liang <mathzhaoliang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
for more information, see https://pre-commit.ci
Applied the changes with some minor changes. Please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one little style issue: We can spell out the numbers below 10 for consistency.
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Added the usage of |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A grammar suggestion. Otherwise it is all fine :)
Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Issue: taichi-dev#5420 ### Brief Summary Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhao Liang <mathzhaoliang@gmail.com> Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Issue: taichi-dev#5420 ### Brief Summary Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhao Liang <mathzhaoliang@gmail.com> Co-authored-by: Olinaaaloompa <106292061+Olinaaaloompa@users.noreply.github.com>
Issue: #5420
Brief Summary