[Lang] Warn users if ndarray size is out of int32 boundary #6846

strongoier · 2022-12-09T03:16:34Z

Issue: fix #6758

Brief Summary

This PR adds a boundary check for ndarray similar to

Lines 89 to 93 in a87b98f

    
           if (acc_shape > std::numeric_limits<int>::max()) { 
        
             TI_WARN( 
        
                 "SNode index might be out of int32 boundary but int64 indexing is not " 
        
                 "supported yet. Struct fors might not work either."); 
        
           }

netlify · 2022-12-09T03:16:40Z

✅ Deploy Preview for docsite-preview ready!

Name	Link
🔨 Latest commit	`cbdb7e2`
🔍 Latest deploy log	https://app.netlify.com/sites/docsite-preview/deploys/6392ac2a2d4b3c0008a7df8d
😎 Deploy Preview	https://deploy-preview-6846--docsite-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

for more information, see https://pre-commit.ci

ailzhang

Thanks!

…v#6846) Issue: fix taichi-dev#6758 ### Brief Summary This PR adds a boundary check for ndarray similar to https://github.com/taichi-dev/taichi/blob/a87b98fd40fc93dbe1bdf8c4e3932a6078379fa3/taichi/ir/snode.cpp#L89-L93 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

[Lang] Warn users if ndarray size out of int32

e64b3d5

pre-commit-ci bot and others added 3 commits December 9, 2022 03:17

[pre-commit.ci] auto fixes from pre-commit.com hooks

00457f9

for more information, see https://pre-commit.ci

Add initial value

a6ce56c

[pre-commit.ci] auto fixes from pre-commit.com hooks

cbdb7e2

for more information, see https://pre-commit.ci

strongoier requested review from ailzhang, jim19930609 and lin-hitonami December 13, 2022 02:11

ailzhang approved these changes Dec 13, 2022

View reviewed changes

strongoier merged commit 96e7957 into taichi-dev:master Dec 13, 2022

strongoier deleted the fix-6758 branch December 13, 2022 07:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lang] Warn users if ndarray size is out of int32 boundary #6846

[Lang] Warn users if ndarray size is out of int32 boundary #6846

strongoier commented Dec 9, 2022

netlify bot commented Dec 9, 2022 •

edited

Loading

ailzhang left a comment

	if (acc_shape > std::numeric_limits<int>::max()) {
	TI_WARN(
	"SNode index might be out of int32 boundary but int64 indexing is not "
	"supported yet. Struct fors might not work either.");
	}

[Lang] Warn users if ndarray size is out of int32 boundary #6846

[Lang] Warn users if ndarray size is out of int32 boundary #6846

Conversation

strongoier commented Dec 9, 2022

Brief Summary

netlify bot commented Dec 9, 2022 • edited Loading

✅ Deploy Preview for docsite-preview ready!

ailzhang left a comment

Choose a reason for hiding this comment

netlify bot commented Dec 9, 2022 •

edited

Loading