Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Add warning message when converting dynamic snode to numpy #6853

Merged
merged 2 commits into from
Dec 14, 2022
Merged

[Lang] Add warning message when converting dynamic snode to numpy #6853

merged 2 commits into from
Dec 14, 2022

Conversation

neozhaoliang
Copy link
Contributor

@neozhaoliang neozhaoliang commented Dec 9, 2022

This PR adds a warning message when the user tries to call the to_numpy method of a dynamic snode.

close: #6841

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 0a53cec
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6392fde78209210008c4b32e
😎 Deploy Preview https://deploy-preview-6853--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@neozhaoliang neozhaoliang changed the title [Lang] Add warning when converting dynamic snode to numpy [Lang] Add warning message when converting dynamic snode to numpy Dec 9, 2022
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@neozhaoliang neozhaoliang merged commit 5ed0dc4 into taichi-dev:master Dec 14, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…ichi-dev#6853)

This PR adds a warning message when the user tries to call the
`to_numpy` method of a dynamic snode.

close: taichi-dev#6841

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For dynamic snodes, calling to_numpy() results a whole array padded with zeros, not the actual length
2 participants