Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Allow a maximum of 12 SNode indices #6901

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

AmesingFlank
Copy link
Collaborator

Fixes #6900

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 7946037
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/639ac6332b1cbe0008d7339a
😎 Deploy Preview https://deploy-preview-6901--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc needs to be updated as well:

Taichi supports up to 8 (`constexpr int taichi_max_num_indices = 8`)
virtual indices and physical indices.

@strongoier strongoier merged commit 45f4045 into taichi-dev:master Dec 15, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increasing the maximum amount of field indices allowed
2 participants