[Lang] [metal] Support dynamic indexing in metal #6985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
for more information, see https://pre-commit.ci
strongoier
requested review from
jim19930609,
ailzhang and
k-ye
and removed request for
jim19930609 and
ailzhang
feisuzhu
pushed a commit
to feisuzhu/taichi
that referenced
this pull request
Jan 5, 2023
Issue: taichi-dev#2590 ### Brief Summary This PR supports dynamic indexing in spirv (sister PR: taichi-dev#6985). `_test_local_matrix_non_constant_index()` is modified due to lack of `AssertStmt` support in spirv. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#2590 ### Brief Summary 1. Dynamic indexing in metal is supported by mimicking the implementation of that in LLVM backends. 2. `ret_type` change of `ArgLoadStmt` is moved out of the `ScalarizePointers` pass, which is designed to scalarize `alloca` and will be removed once dynamic indexing becomes default. 3. Configs of dynamic indexing tests are fixed. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#2590 ### Brief Summary This PR supports dynamic indexing in spirv (sister PR: taichi-dev#6985). `_test_local_matrix_non_constant_index()` is modified due to lack of `AssertStmt` support in spirv. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2590
Brief Summary
ret_typechange ofArgLoadStmtis moved out of theScalarizePointerspass, which is designed to scalarizeallocaand will be removed once dynamic indexing becomes default.