-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aot] Deprecate element shape and field dim for AOT symbolic args #7100
Merged
turbo0628
merged 13 commits into
taichi-dev:master
from
turbo0628:symbolic-args-cleanup
Jan 10, 2023
Merged
[Aot] Deprecate element shape and field dim for AOT symbolic args #7100
turbo0628
merged 13 commits into
taichi-dev:master
from
turbo0628:symbolic-args-cleanup
Jan 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
…nto symbolic-args-cleanup
lin-hitonami
reviewed
Jan 9, 2023
for more information, see https://pre-commit.ci
…nto symbolic-args-cleanup
for more information, see https://pre-commit.ci
…nto symbolic-args-cleanup
ailzhang
reviewed
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ailzhang
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
lin-hitonami
pushed a commit
to lin-hitonami/taichi
that referenced
this pull request
Jan 11, 2023
…ichi-dev#7100) Issue: taichi-dev#6572 * Fix using dtype for symbolic args in AOT usages * Cleanup all the usages of `field_dim` and `element_shape` in examples and tests
lin-hitonami
pushed a commit
to lin-hitonami/taichi
that referenced
this pull request
Jan 12, 2023
…ichi-dev#7100) Issue: taichi-dev#6572 * Fix using dtype for symbolic args in AOT usages * Cleanup all the usages of `field_dim` and `element_shape` in examples and tests
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…ichi-dev#7100) Issue: taichi-dev#6572 * Fix using dtype for symbolic args in AOT usages * Cleanup all the usages of `field_dim` and `element_shape` in examples and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6572
field_dim
andelement_shape
in examples and tests