Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aot] Deprecate element shape and field dim for AOT symbolic args #7100

Merged
merged 13 commits into from
Jan 10, 2023

Conversation

turbo0628
Copy link
Member

Issue: #6572

  • Fix using dtype for symbolic args in AOT usages
  • Cleanup all the usages of field_dim and element_shape in examples and tests

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 03341a0
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63bc1d33fb39ce00079f5f33
😎 Deploy Preview https://deploy-preview-7100--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@turbo0628 turbo0628 added this to the v1.4.0 milestone Jan 9, 2023
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

python/taichi/graph/_graph.py Show resolved Hide resolved
python/taichi/graph/_graph.py Outdated Show resolved Hide resolved
python/taichi/graph/_graph.py Outdated Show resolved Hide resolved
tests/cpp/aot/python_scripts/comet_aot.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turbo0628 turbo0628 merged commit 6f8e0ed into taichi-dev:master Jan 10, 2023
lin-hitonami pushed a commit to lin-hitonami/taichi that referenced this pull request Jan 11, 2023
…ichi-dev#7100)

Issue: taichi-dev#6572 

* Fix using dtype for symbolic args in AOT usages
* Cleanup all the usages of `field_dim` and `element_shape` in examples and tests
lin-hitonami pushed a commit to lin-hitonami/taichi that referenced this pull request Jan 12, 2023
…ichi-dev#7100)

Issue: taichi-dev#6572 

* Fix using dtype for symbolic args in AOT usages
* Cleanup all the usages of `field_dim` and `element_shape` in examples and tests
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…ichi-dev#7100)

Issue: taichi-dev#6572 

* Fix using dtype for symbolic args in AOT usages
* Cleanup all the usages of `field_dim` and `element_shape` in examples and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants