[Lang] Raise errors when using the packed switch #7125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lin-hitonami
pushed a commit
that referenced
this pull request
Jan 12, 2023
### Brief Summary The `packed` switch of `ti.init()` should be removed according to the [deprecation notice](https://github.com/taichi-dev/taichi/releases/tag/v1.3.0). However, to avoid a large changeset immediately before release (#7104), let's raise errors first and get that in later. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lin-hitonami
pushed a commit
that referenced
this pull request
Jan 12, 2023
### Brief Summary The `packed` switch of `ti.init()` should be removed according to the [deprecation notice](https://github.com/taichi-dev/taichi/releases/tag/v1.3.0). However, to avoid a large changeset immediately before release (#7104), let's raise errors first and get that in later. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lin-hitonami
pushed a commit
that referenced
this pull request
Jan 12, 2023
### Brief Summary The `packed` switch of `ti.init()` should be removed according to the [deprecation notice](https://github.com/taichi-dev/taichi/releases/tag/v1.3.0). However, to avoid a large changeset immediately before release (#7104), let's raise errors first and get that in later. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
strongoier
added a commit
that referenced
this pull request
Jan 13, 2023
### Brief Summary This is a follow-up PR of #7125 to fully remove the `packed` switch. Changes to `ArithmeticInterpretor` are included to pass the `ScalarPointerLowererTest.Basic` test, which now switches running mode (packed) and generates different IR. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
### Brief Summary The `packed` switch of `ti.init()` should be removed according to the [deprecation notice](https://github.com/taichi-dev/taichi/releases/tag/v1.3.0). However, to avoid a large changeset immediately before release (taichi-dev#7104), let's raise errors first and get that in later. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
### Brief Summary This is a follow-up PR of taichi-dev#7125 to fully remove the `packed` switch. Changes to `ArithmeticInterpretor` are included to pass the `ScalarPointerLowererTest.Basic` test, which now switches running mode (packed) and generates different IR. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary
The
packedswitch ofti.init()should be removed according to the deprecation notice. However, to avoid a large changeset immediately before release (#7104), let's raise errors first and get that in later.