Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update accelerate_python.md to use ti.max #7161

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

tao-j
Copy link
Contributor

@tao-j tao-j commented Jan 14, 2023

newer version of ti deprecates max

Issue: #

Brief Summary

newer version of ti deprecates `max`
@netlify
Copy link

netlify bot commented Jan 14, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 9ee56de
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63c2d53761d2370009c66c60
😎 Deploy Preview https://deploy-preview-7161--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2023

CLA assistant check
All committers have signed the CLA.

@tao-j tao-j changed the title Update accelerate_python.md [doc] Update accelerate_python.md to use ti.max Jan 14, 2023
@tao-j
Copy link
Contributor Author

tao-j commented Jan 14, 2023

https://docs.taichi-lang.org/docs/cloth_simulation
also needs to be updated from min to ti.min.

I am not adding more commits now since it is going to trigger another CI run, and it seems that you have a long pipeline....

Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@neozhaoliang neozhaoliang merged commit 7f2468f into taichi-dev:master Jan 15, 2023
lin-hitonami pushed a commit that referenced this pull request Jan 16, 2023
newer version of ti deprecates `max`

Issue: #

### Brief Summary
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
newer version of ti deprecates `max`

Issue: #

### Brief Summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants