[misc] Ensure succeeded variable is properly initialized in matrix-free solvers #8484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
liblaf
changed the title
succeeded variable is properly initialized in matrix-free solvers
|
/rebase |
…ree solvers The `succeeded` variable was not properly initialized in the `MatrixFreeCG` and `MatrixFreeBICGSTAB` functions, leading to potential issues with the convergence check. By initializing the `succeeded` variable at the beginning of the `solve` function, we ensure that the variable is correctly set and returned at the end of the function, improving the reliability of the solvers.
yuanming-hu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
succeededvariable was not properly initialized in theMatrixFreeCGandMatrixFreeBICGSTABfunctions, leading to potential issues with the convergence check. By initializing thesucceededvariable at the beginning of thesolvefunction, we ensure that the variable is correctly set and returned at the end of the function, improving the reliability of the solvers.Issue: #
Brief Summary
copilot:summary
Walkthrough
copilot:walkthrough