Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix bug to disable taichi header print #8517

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

mushroomfire
Copy link
Contributor

Issue: #8334

Brief Summary

The previous code #8413 had no effect because the value in os.environ can only be a string. This pull request will enable users to disable the Taichi header print by setting one of the following ways:

  • os.environ['ENABLE_TAICHI_HEADER_PRINT'] = 'False'
  • os.environ['ENABLE_TAICHI_HEADER_PRINT'] = 'FALSE'
  • os.environ['ENABLE_TAICHI_HEADER_PRINT'] = 'F'
  • os.environ['ENABLE_TAICHI_HEADER_PRINT'] = '0'

Walkthrough

copilot:walkthrough

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 8c62aa5
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6677810d92484c0008b67aa4
😎 Deploy Preview https://deploy-preview-8517--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bobcao3
Copy link
Collaborator

bobcao3 commented Apr 25, 2024

/rebase

1 similar comment
@bobcao3
Copy link
Collaborator

bobcao3 commented Jun 23, 2024

/rebase

Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobcao3 bobcao3 merged commit b649d14 into taichi-dev:master Jun 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants