[ir][refactor] Move all frontend stmts to frontend_ir.h
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
suggested changes
May 3, 2020
| stmt = stmt_tmp.get(); | ||
| current_ast_builder().insert(std::move(stmt_tmp)); | ||
| } | ||
| explicit If(const Expr &cond); |
There was a problem hiding this comment.
If and While are still in ir.h? Wasn't it about frontend?
There was a problem hiding this comment.
Thanks! I think these are legacy stuff -- when Taichi was provided in C++14 before integrated in Python3. @yuanming-hu could you confirm?
There was a problem hiding this comment.
Yes, they are for the legacy C++14 frontend and should be removed in a future PR.
| @@ -1005,4 +1005,34 @@ bool ContinueStmt::as_return() const { | |||
| return false; | |||
| } | |||
|
|
|||
| If::If(const Expr &cond) { | |||
| auto stmt_tmp = std::make_unique<FrontendIfStmt>(cond); | |||
There was a problem hiding this comment.
Here. So it should be in frontend_ir.cpp?
|
OK, let's leave these legacy stuff in Line 161 in 0c3358e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #914 . We move all
Frontend*Stmttofrontend_ir.h. (Expressions will be handled separately)Related issue = #689
[Click here for the format server]