Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240209【Ruby】プログラムの修正 #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions cafe.rb
Original file line number Diff line number Diff line change
@@ -1,34 +1,34 @@
# frozen_string_literal: true

DRINKS = [
{ name: 'コーヒー', price: '300' },
{ name: 'カフェラテ', price: '400' },
{ name: 'チャイ', price: '460' },
{ name: 'エスプレッソ', price: '340' },
{ name: '緑茶', price: '450' }
{ name: 'コーヒー', price: 300 },
{ name: 'カフェラテ', price: 400 },
{ name: 'チャイ', price: 460 },
{ name: 'エスプレッソ', price: 340 },
{ name: '緑茶', price: 450 }
].freeze

FOODS = [
{ name: 'チーズケーキ', price: '470' },
{ name: 'アップルパイ', price: '520' },
{ name: 'ホットサンド', price: '410' }
{ name: 'チーズケーキ', price: 470 },
{ name: 'アップルパイ', price: 520 },
{ name: 'ホットサンド', price: 410 }
].freeze

def take_order(menus)
menus.each.with_index(1) do |menu, i|
puts "(#{i})#{menu[:name]}: #{menu[:price]}円"
end
print '>'
order_number = gets.to_i
order_number = gets.to_i - 1
puts "#{menus[order_number][:name]}(#{menus[order_number][:price]}円)ですね。"
order_number
end

puts 'bugカフェへようこそ!ご注文は? 番号でどうぞ'
order1 = take_order(DRINKS)
drink = take_order(DRINKS)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これだと飲み物そのものが変数に格納されてそうな印象を受けます。
あくまで注文の情報なので、 drink_order (飲み物の注文)みたいな名前の方が良いと思います。

メソッド名と変数名の対応関係、という観点でも命名を確認してみるとよいかもしれません。
https://bootcamp.fjord.jp/pages/readable-variable-name


puts 'フードメニューはいかがですか?'
order2 = take_order(FOODS)
food = take_order(FOODS)

total = FOODS[order1][:price] + DRINKS[order2][:price]
total = DRINKS[drink][:price] + FOODS[food][:price]
puts "お会計は#{total}円になります。ありがとうございました!"