fix(eslint-plugin-experience): use Set for optimize search expression

taiga-family · Mar 25, 2024 · a545426 · a545426
1 parent b6e9573
commit a545426
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 22 deletions.
diff --git a/nx.json b/nx.json
@@ -1,16 +1,4 @@
 {
-    "tasksRunnerOptions": {
-        "default": {
-            "runner": "nx-cloud",
-            "options": {
-                "cacheableOperations": ["test", "build"],
-                "parallel": 1
-            }
-        }
-    },
-    "affected": {
-        "defaultBase": "origin/main"
-    },
     "workspaceLayout": {
         "libsDir": "projects",
         "appsDir": "projects"
@@ -28,6 +16,14 @@
         ],
         "production": ["default"]
     },
-    "targetDefaults": {},
-    "nxCloudAccessToken": "ZmQxN2Q4MmQtNzQ3OC00MDQ0LTg2MTYtNGE3OGU5NDQwNTk3fHJlYWQtd3JpdGU="
+    "targetDefaults": {
+        "test": {
+            "cache": true
+        },
+        "build": {
+            "cache": true
+        }
+    },
+    "defaultBase": "origin/main",
+    "parallel": 1
 }
diff --git a/projects/eslint-plugin-experience/rules/no-simple-for-of.js b/projects/eslint-plugin-experience/rules/no-simple-for-of.js
@@ -9,13 +9,16 @@ module.exports = {
              * @return {*}
              */
             ForOfStatement(node) {
-                const isSimpleForOf = !findExpressions(node, [
-                    'AwaitExpression',
-                    'YieldExpression',
-                    'BreakStatement',
-                    'ContinueStatement',
-                    'ReturnStatement',
-                ]);
+                const isSimpleForOf = !findExpressions(
+                    node,
+                    new Set([
+                        'AwaitExpression',
+                        'YieldExpression',
+                        'BreakStatement',
+                        'ContinueStatement',
+                        'ReturnStatement',
+                    ]),
+                );
 
                 if (isSimpleForOf) {
                     context.report({
@@ -33,7 +36,7 @@ module.exports = {
 };
 
 function findExpressions(node, keys) {
-    if (keys.includes(node?.type) || keys.includes(node?.expression?.type)) {
+    if (keys.has(node?.type) || keys.has(node?.expression?.type)) {
         return true;
     }