Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the value in the component is incorrectly updated when it is passed as an empty string using formControl #1558

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: the value in the component is incorrectly updated when it is passed as an empty string using formControl #1558

merged 2 commits into from
Nov 18, 2024

Conversation

splincode
Copy link
Member

Fixes #1522

@splincode splincode requested a review from a team as a code owner November 12, 2024 08:53
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 12, 2024 08:53
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 12, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 57bc74c):

https://taiga-editor--pr1558-splincode-fix-reset-pr6pjh96.web.app

(expires Sat, 16 Nov 2024 10:15:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c332df40371bee0fa68e2139313c6db411ab5f82

@splincode splincode force-pushed the splincode/fix-reset branch 13 times, most recently from 4808762 to cceacc8 Compare November 12, 2024 12:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3c80ca1):

https://taiga-editor-e2e-report--pr1558-splincode-fix-reset-mwa10zrf.web.app

(expires Wed, 13 Nov 2024 13:15:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 614609c963024da268d676cbcf03c91219a10ca0

@splincode splincode force-pushed the splincode/fix-reset branch 6 times, most recently from d057995 to cd7a2b7 Compare November 13, 2024 12:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Playwright test results

failed  3 failed
passed  14 passed

Details

stats  17 tests across 7 suites
duration  36.7 seconds
commit  57bc74c
info  For more information, see our report

Failed tests

chromium › tests/anchors.spec.ts › Anchors › viewport position
chromium › tests/groups.spec.ts › Groups › draggable groups
chromium › tests/reset.spec.ts › Reset › Correct reset value from wysiwyg

@github-actions github-actions bot added the ready to merge ready label Nov 18, 2024
@splincode splincode merged commit 3493434 into main Nov 18, 2024
12 of 14 checks passed
@splincode splincode deleted the splincode/fix-reset branch November 18, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@splincode splincode

Labels
ready to merge ready
Projects
None yet
Milestone
No milestone
2 participants
@splincode @vladimirpotekhin