Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regression for anchor links #1610

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: regression for anchor links #1610

merged 1 commit into from
Nov 27, 2024

Conversation

splincode
Copy link
Member

Fixes #1594

@splincode splincode requested a review from a team as a code owner November 26, 2024 14:31
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 26, 2024 14:31
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 26, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit d5d1d33):

https://taiga-editor--pr1610-splincode-fix-demo-y4g8uwhe.web.app

(expires Thu, 28 Nov 2024 08:17:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c332df40371bee0fa68e2139313c6db411ab5f82

@splincode splincode force-pushed the splincode/fix branch 2 times, most recently from 3a55ca3 to ea49507 Compare November 26, 2024 14:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Playwright test results

failed  1 failed
passed  17 passed

Details

stats  18 tests across 7 suites
duration  29.4 seconds
commit  d5d1d33
info  For more information, see our report

Failed tests

chromium › tests/anchors.spec.ts › Anchors › make anchor

@github-actions github-actions bot added the ready to merge ready label Nov 27, 2024
@splincode splincode merged commit e724d90 into main Nov 27, 2024
12 of 14 checks passed
@splincode splincode deleted the splincode/fix branch November 27, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@splincode splincode

Labels
ready to merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - id is not created when adding anchor
2 participants
@splincode @vladimirpotekhin